My DigitalWrite code is not triggereing my device

1

Hello, so I have a problem with my digitalwrite to a pin. When the below code runs, HEATER1 turns off, and PUMP turns on; but my HEATER2 does not turn off. In seperate parts of the code, I can manually turn HEATER2 on and off so I dont think its a hardware issue, but I am not sure where the software issue is because I am using digitalwrite the same ways.

The only thing I can think of is that you cant have three digitalwrites in a row. Is this possibly the problem? THanks!

case 3:
    switchState = 0;
    mashrun = true;
    premash=false;
    MashStartTime = (millis()/60000);   
    digitalWrite(HEATER1, LOW);
    digitalWrite(HEATER2, LOW);
    digitalWrite(PUMP, HIGH);
    tone(BUZZER,500,2000);
    terminal.println("Mash temp hit, mash begin");
    terminal.flush();
break;
2

Nah, you can have heaps of digital writes in a row , I think i have 12 at some points in my code …

Have you tested the hardware wit an led instead of a relay?

Is that the only place you switch both heaters at the same time?

3

I have switched both ON at the same time with no issues, and like I said I can individually control the heater 2 ON and OFF with no issues

4

can you see it in the serial output?

oh, and obvious question, how do you know it is not turning off?

5

We can’t do much without the rest of the code. It could be anywhere, so if it’s not too big, is it possible to post the entire code?

6

@Dave1829 I haven’t been printing to serial, but I am printing to the terminal widget and the print out is working.

Its a heating elements, so in the water when its on it bubbles etc, and when off nothing happens so I can tell it is definitely still on.

@Lichtsignaal The code is below, its pretty long, but if you go to case 3 in the “Autobrewing” section of the code, which is the Mash start that is where the heaters should turn off and the pump on.

//////////////////////BLYNK CODE
//#define BLYNK_PRINT Serial  
#include <ESP8266WiFi.h>
#include <BlynkSimpleEsp8266.h>
#include <SimpleTimer.h>
SimpleTimer timer;
const char* ssid = "";
const char* password = "";
char auth[] = "";
WidgetTerminal terminal(V0);
WidgetTerminal terminalHops(V14);

////////Setting up variables to be declared by Blynk app
int MASHTEMP; // Desired Mash Temp(deg F)
int MASHTIME; //Desired Mash Time(milli sec.)
int BOILTIME; //Desired Boil Time(milli sec.)
int CHILLTIME; //Desired time to pump all wort through the wort chiller (milli sec.)
int hopCounter; //Number of hop adds that I input, based upon my terminal input
int HopAddtime;
int HOPTIME[20]; // Hop times
String HOPINFO[20];  // HOPINFO;

////////////Assign counters for independent and pause control buttons
int noButtonCounter;
int pacounter;
int pucounter;
int h1counter;
int h2counter;

////////////////////////Assign variables
float tanktemp; //Declaring temperature variables
unsigned long btstart;
unsigned long btstart1;
unsigned long btstart2;
unsigned long pausestart; //Time when pause button was pushed
unsigned long elapsedpausetime;
unsigned long elapsedpumptime;
unsigned long elapsedh1time;
unsigned long elapsedh2time;
unsigned long totalpausem;
unsigned long totalpauseb;
unsigned long totalpausec;
unsigned long startingtime; //overall starting time
unsigned long ElapsedPreMashTime;
unsigned long MashStartTime; //used for MASH TIME
unsigned long ElapsedMashTime;
unsigned long BoilStartTime; //used for BOIL TIME
unsigned long ElapsedBoilTime;
unsigned long ChillStartTime; //used for BOIL TIME
unsigned long ElapsedChillTime;


//Setup all states
int switchState;
boolean autostart = true;
boolean premash;
boolean mashPID;
boolean reheatpremash;
boolean mashrun;
boolean mashreheat;
boolean mashend;
boolean boilrun;
boolean reboil;
boolean boilend;
boolean chillrun;
boolean rechill;
boolean chillend;

//Pin Inputs/Outputs to Arduino:
const int BUZZER = D0;
const int HEATER1 = D5;
const int HEATER2 = D6;
const int PUMP = D7;

//Status variables for buttons
int val_start; 
int val_pause;
int val_pump;
int val_heater1;
int val_heater2;


void brewingstuff(){
  
//No button pressed nothing is on (Also works so that when Auto button is on and then turned off, everything shuts down
if (val_start == LOW && val_pause == LOW && val_pump == LOW && val_heater1 == LOW && val_heater2 == LOW){
      switch (noButtonCounter){
      case 0:
         digitalWrite(HEATER1, LOW);
         digitalWrite(HEATER2, LOW);
         digitalWrite(PUMP, LOW);
         terminal.println("No Button Pressed, to pause must press pause button!");
         terminal.flush();
         noButtonCounter = 1;
         pausestart = (millis()/60000);
      break;
      case 1:
       elapsedpausetime = ((millis()/60000) - pausestart);
       terminal.print("No button pressed for:  ");
       terminal.println(elapsedpausetime);
       terminal.flush();
      break;} 
  }

//If anything is pressed right after no button was pressed, reset no button counter, set re heat states if needed, and increase "pause" time
if ((val_start == HIGH || val_pause == HIGH || val_pump == HIGH || val_heater1 == HIGH || val_heater2 == HIGH) && noButtonCounter == 1){
        noButtonCounter = 0; 
        if (premash == true){
          reheatpremash = true; 
        }
        else if (mashrun == true){
          totalpausem = totalpausem + elapsedpausetime;
          terminal.print("Time Added to Mash: ");
          terminal.println(elapsedpausetime); 
        }
       else if (boilrun == true){
          reboil = true;
          totalpauseb = totalpauseb + elapsedpausetime;
          terminal.print("Time Added to Boil: ");
          terminal.println(elapsedpausetime);  
       }
       else if (chillrun == true){
          rechill = true;
          totalpausec = totalpausec + elapsedpausetime; 
          terminal.print("Time Added to Chill: ");
          terminal.println(elapsedpausetime); 
          
       }  
   elapsedpausetime=0;
  }
  
//pause stops everything  
if (val_pause == HIGH){
       switch (pacounter){
       case 0:
        Blynk.virtualWrite(V4,LOW);
        Blynk.virtualWrite(V6,LOW);
        Blynk.virtualWrite(V7,LOW);
        Blynk.virtualWrite(V8,LOW);
        val_start=LOW; 
        val_pump=LOW;
        val_heater1=LOW;
        val_heater2=LOW;
        pucounter=0;
        h1counter=0;
        h2counter=0;
        pausestart=(millis()/60000);
        pacounter=1;
        digitalWrite(HEATER1, LOW);
        digitalWrite(HEATER2, LOW);
        digitalWrite(PUMP, LOW);
        terminal.println("PAUSE WORKING");
      break;
      case 1:
       elapsedpausetime = ((millis()/60000) - pausestart);
       terminal.print("Manual Pause for: ");
       terminal.println(elapsedpausetime);
       terminal.flush();
      break;} 
  }
///Pause button on and then turned off it resets counter, re heats if needed, and increased pause time
if (pacounter == 1 && val_pause == LOW){
       pacounter = 0;
        if (premash == true){
          reheatpremash = true; 
        }
        else if (mashrun == true){
          totalpausem = totalpausem + elapsedpausetime; 
          terminal.print("Time Added to Mash: ");
          terminal.println(elapsedpausetime); 
        }
       else if (boilrun == true){
          reboil = true;
          totalpauseb = totalpauseb + elapsedpausetime;
          terminal.print("Time Added to Boil: ");
          terminal.println(elapsedpausetime);  
       }
       else if (chillrun == true){
          rechill = true;
          totalpausec = totalpausec + elapsedpausetime; 
          terminal.print("Time Added to Chill: ");
          terminal.println(elapsedpausetime); 
       }  
     elapsedpausetime=0;     
    }

//Button pressed on pump starts
if (val_start == LOW && val_pause == LOW && val_pump == HIGH){
      switch (pucounter){
       case 0:
        terminal.println("Pump starting, need to open ball valve!!");
        terminal.flush();
        tone(BUZZER,500,5000);
        digitalWrite(PUMP, HIGH);
        btstart=(millis()/60000);
        pucounter=1;
       break;
       case 1:
        elapsedpumptime = ((millis()/60000) - btstart);
        terminal.print("Manual Pump On for: ");
        terminal.println(elapsedpumptime);
        terminal.flush(); 
       break;
      }  

  }
///Pump button on and then turned off it stops pump
if (pucounter == 1 && val_pump == LOW){
    pucounter = 0;
    digitalWrite(PUMP, LOW);
        if (premash == true){
          reheatpremash = true; 
        }
        else if (mashrun == true){
          totalpausem = totalpausem + elapsedpumptime;
          terminal.print("Time Added to Mash: ");
          terminal.println(elapsedpausetime);  
        }
       else if (boilrun == true){
          reboil = true;
          totalpauseb = totalpauseb + elapsedpumptime;
          terminal.print("Time Added to Boil: ");
          terminal.println(elapsedpausetime);  
       }
       else if (chillrun == true){
          rechill = true;
          totalpausec = totalpausec + elapsedpumptime;
          terminal.print("Time Added to Chill: ");
          terminal.println(elapsedpausetime);  
       }
    elapsedpumptime = 0;  
  }

//Heater 1 button pressed on heater starts
if (val_start == LOW && val_pause == LOW && val_heater1 == HIGH){
      switch (h1counter) {
      case 0: 
        btstart1=(millis()/60000);
        tone(BUZZER,500,5000);
        terminal.println("Heat 1 starting, need cover w water!!");
        terminal.flush();
        digitalWrite(HEATER1, HIGH);
        h1counter=1;
      break;
      case 1: 
       elapsedh1time = ((millis()/60000) - btstart1);
       terminal.print("Manual Heater 1 On for: ");
       terminal.println(elapsedh1time);
       terminal.flush();
      break; } 
  } 
///When Heater1 button on and then turned off it stops one heater
if (h1counter == 1 && val_heater1 == LOW){
        h1counter = 0;
        digitalWrite(HEATER1, LOW);
        if (premash == true){
          reheatpremash = true; 
        }
        else if (mashrun == true){
          totalpausem = totalpausem + elapsedh1time;
          terminal.print("Time Added to Mash: ");
          terminal.println(elapsedpausetime);  
        }
       else if (boilrun == true){
          reboil = true;
          totalpauseb = totalpauseb + elapsedh1time; 
          terminal.print("Time Added to Boil: ");
          terminal.println(elapsedpausetime); 
       }
       else if (chillrun == true){
          rechill = true;
          totalpausec = totalpausec + elapsedh1time;
          terminal.print("Time Added to Chill: ");
          terminal.println(elapsedpausetime);  
       }  
    elapsedh1time=0; 
  }

  
if (val_start == LOW && val_pause == LOW && val_heater2 == HIGH){
      switch (h2counter){
      case 0:
        btstart2=(millis()/60000);
        tone(BUZZER,500,5000);
        terminal.println("Heat 2 starting, need cover w water!!");
        terminal.flush();
        digitalWrite(HEATER2, HIGH);
        h2counter=1;
      break;
      case 1:
       elapsedh2time = ((millis()/60000) - btstart2);
       terminal.print("Manual Heater 2 On for: ");
       terminal.println(elapsedh2time);
       terminal.flush();
      break;} 
  } 
///When Heater2 button on and then turned off it stops two heater
if (h2counter == 1 && val_heater2 == LOW){
        h2counter = 0;
        digitalWrite(HEATER2, LOW);
        if (premash == true){
          reheatpremash = true; 
        }
        else if (mashrun == true){
          totalpausem = totalpausem + elapsedh2time; 
          terminal.print("Time Added to Mash: ");
          terminal.println(elapsedpausetime); 
        }
       else if (boilrun == true){
          reboil = true;
          totalpauseb = totalpauseb + elapsedh2time;
          terminal.print("Time Added to Boil: ");
          terminal.println(elapsedpausetime);  
       }
       else if (chillrun == true){
          rechill = true;
          totalpausec = totalpausec + elapsedh2time;
          terminal.print("Time Added to Chill: ");
          terminal.println(elapsedpausetime);  
       }  
    elapsedh2time=0;
  }

//Auto Brewing State decision upfront
ElapsedPreMashTime = (millis()/60000) - startingtime;
ElapsedMashTime = (millis()/60000) - MashStartTime - totalpausem;
ElapsedBoilTime = (millis()/60000) - BoilStartTime - totalpauseb;
ElapsedChillTime = (millis()/60000) - ChillStartTime - totalpausec;

if (tanktemp < MASHTEMP && autostart == true && switchState ==0) {
  switchState=1;
}

else if (tanktemp >= MASHTEMP - 5.0 && tanktemp < MASHTEMP - 2.0 && premash == true && mashPID == false && switchState ==0) { 
  switchState=2;
}

else if (tanktemp >= MASHTEMP - 2.0 && tanktemp <= MASHTEMP + 2.0 && premash == true && switchState ==0) { 
  switchState=3;
}

else if (tanktemp <= MASHTEMP - 8.0 && mashrun == true && mashreheat == false && switchState ==0){ 
  switchState=4;
}

else if (tanktemp >= MASHTEMP && mashreheat == true && switchState ==0){
  switchState=5;
}

else if (ElapsedMashTime >= MASHTIME && mashrun == true && switchState ==0) { 
  switchState=6;
}

else if (tanktemp >= 200 && mashend == true && switchState ==0) { 
  switchState=7;
}

else if (reboil == true && switchState ==0){ 
  switchState=8;
}

else if (ElapsedBoilTime < BOILTIME + 1 && boilrun == true && switchState ==0) {
  switchState=9;
  if (ElapsedBoilTime >= BOILTIME - 8 && ElapsedBoilTime <= BOILTIME - 7){
    terminal.println("Boil Almost Done: Add Immersion Chiller & begin yeast starter");
    terminal.flush();
  }
}

else if (ElapsedBoilTime >= BOILTIME && boilrun == true && switchState ==0) { 
  switchState=10;
}

else if (tanktemp <= 190 && boilend == true && switchState ==0) {
  switchState=11;
}

else if (rechill == true && switchState ==0){ 
  switchState=12;
}

else if (ElapsedChillTime >= CHILLTIME && chillrun == true && switchState ==0) { 
  switchState=13;
}

else if (reheatpremash == true && switchState ==0) { 
  switchState=14;
}


//When Auto Brewing Start button pressed 
if (val_start == HIGH && val_pause == LOW && val_pump == LOW && val_heater1 == LOW && val_heater2 == LOW){

switch (switchState){
//premash = Heater 1 & 2 on, pump off
case 1: 
      switchState = 0;
      startingtime = (millis()/60000);
      terminal.println(startingtime);
      premash=true;
      autostart = false;
      tone(BUZZER,500,5000);
      terminal.println("Heat starting, need to cover with water!!");
      terminal.flush();
      digitalWrite(HEATER1, HIGH);
      digitalWrite(HEATER2, HIGH);
      terminal.println("Heaters On");
      terminal.flush();    
break;


//reheatpremash: turn heaters back on after a pause during premash stage
case 14:
    switchState = 0;
    reheatpremash = false;
    digitalWrite(HEATER1, HIGH);
    digitalWrite(HEATER2, HIGH);
    terminal.println("Back from pause, premash heaters back on");
    terminal.flush(); 
break;


//close to mash temp = only one heater stay on (MY VERSION OF A PID)
case 2: 
    Blynk.notify("Close to MashTemp, ready to insert grain");
    switchState = 0;
    mashPID = true;
    digitalWrite(HEATER2, HIGH);
    tone(BUZZER,500,2000);
    terminal.println("Temp close to Mash, one heater on");
    terminal.flush();
break;

//mashrun = heaters off, pump on
case 3:
    switchState = 0;
    mashrun = true;
    premash=false;
    MashStartTime = (millis()/60000);   
    digitalWrite(HEATER1, LOW);
    digitalWrite(HEATER2, LOW);
    tone(BUZZER,500,2000);
    terminal.println("Mash temp hit, mash begin");
    terminal.flush();
    digitalWrite(PUMP, HIGH);
break;

//Mash Reheat Adds function so that if paused or a lot of heat loss the heater keeps us at mash temp
case 4:
  switchState = 0;
  mashreheat = true;
  digitalWrite(HEATER1, HIGH);
  digitalWrite(HEATER2, HIGH);
  terminal.println("Heat loss, heaters back on");
  terminal.flush();
break;

//Mash Reheat Complete
case 5: 
  switchState = 0;
  mashreheat = false;
  digitalWrite(HEATER1, LOW);
  digitalWrite(HEATER2, LOW);
  terminal.println("Mash back up to temp, heaters back off");
  terminal.flush();
break;

//mashend = heaters both on, pump off
case 6:
    switchState = 0;
    mashend = true;
    mashrun = false;
    digitalWrite(HEATER1, HIGH);
    digitalWrite(HEATER2, HIGH);
    digitalWrite(PUMP, LOW);
    tone(BUZZER,500,2000);
    terminal.println("Mash Complete, heat on, pump off, pre boil stage");
    Blynk.notify("REMOVE GRAIN BAG: Mash Complete, heat on, pump off, pre boil stage");
    terminal.flush(); 
break;  

//boilrun
case 7:
    switchState = 0;
    boilrun = true;
    mashend= false;
    BoilStartTime = (millis()/60000);
    tone(BUZZER,500,2000);
    terminal.println("Boiling start, heaters on, pump off, look for hop adds");
    terminal.flush();
break;  

//reboil: turn heaters back on after a pause during boilrun stage
case 8:
    switchState = 0;
    reboil = false;
    digitalWrite(HEATER1, HIGH);
    digitalWrite(HEATER2, HIGH);
    terminal.println("Back from pause, boil started again");
    terminal.flush(); 
break;

//Hop Additions Code
case 9:
  switchState =0;
  for (int h=0 ; h=hopCounter; h++) {
       HopAddtime = HOPTIME[h];
       if (ElapsedBoilTime >= (HopAddtime - 1.0) && ElapsedBoilTime <= (HopAddtime + 1.0)) { //BE SURE THAT THE +/- of the elapsedboil time doesnt result in overlay of two hop additions or else it could be confusing
        tone(BUZZER,500,2000);
        terminal.print("Add: ");
        terminal.println(HOPINFO[h]);
        terminal.flush();
        Blynk.notify(HOPINFO[h]);
        tone(BUZZER,500,2000);
       }
      }
break;
  
//boilend = heat off , pump off
case 10:
    switchState = 0;
    boilend = true;
    boilrun = false;
    digitalWrite(HEATER1, LOW);
    digitalWrite(HEATER2, LOW);
    digitalWrite(PUMP, LOW);
    terminal.println("Boil Complete");
    Blynk.notify("INSERT IMMERSION CHILLER IMMEDIATELY, CONNECT ALL CHILL TUBING, MAKE SURE FERMENTER IS READY:Boil Complete");
    terminal.flush();
break;

//chill run: Turns pump on once temp is low enough that going through plate chiller will work: Maybe bump up this temperature
case 11:
    switchState = 0;
    chillrun = true;
    boilend = false;
    ChillStartTime = (millis()/60000);
    terminal.println("Pump starting, need to open ball valve!!");
    terminal.flush();
    tone(BUZZER,500,5000);
    digitalWrite(PUMP, HIGH);    
break;

//rechill: turn pump back on after a pause during chillrun stage
case 12:
    switchState = 0;
    rechill = false;
    digitalWrite(PUMP, HIGH);
    terminal.println("Back from pause, chill pumping started again");
    terminal.flush(); 
break;

//chillend == turn pump off once estimated chill time is over
case 13:
    switchState = 0;
    chillend = true;
    chillrun = false;
    tone(BUZZER,500,5000);
    digitalWrite(PUMP, LOW); 
    terminal.println("Auto Brewing Complete");
    Blynk.notify("Auto Brewing Complete");  
    terminal.flush();  
break;
  }
 }
}


/////////BLYNK CODE: DISPLAYS AND INPUTS
///////BLYNK DASHBOARD DISPLAYS
//Send tanktemp continuously
BLYNK_READ (V9)
{
  Blynk.virtualWrite(V9,tanktemp);
}

//Send Elapsed Time to BLYNK Dashboard Display
BLYNK_READ(V11)
 {
  if (premash == true)
    Blynk.virtualWrite(V11, ElapsedPreMashTime);
  else if (mashrun == true)
    Blynk.virtualWrite(V11, ElapsedMashTime);
  else if (boilrun == true)
    Blynk.virtualWrite(V11, ElapsedBoilTime);
  else if (chillrun == true)
    Blynk.virtualWrite(V11, ElapsedChillTime);
  else 
    Blynk.virtualWrite(V11, 0);
  }

//Display Phase which corresponds with the elapsed time above
BLYNK_READ(V10)
 {
  if (premash == true){
    Blynk.virtualWrite(V10, "preM");}
  else if (mashrun == true){
    Blynk.virtualWrite(V10, "MASH");}
  else if (mashend == true){
    Blynk.virtualWrite(V10, "preB");}  
  else if (boilrun == true) {
    Blynk.virtualWrite(V10, "BOIL");}
  else if (chillrun == true){
    Blynk.virtualWrite(V10, "CHILL");}
  else {
    Blynk.virtualWrite(V10, "N/A");}
  } 

//////////////////////USER INPUTS: Mash Time, Mash Temp, Boil Time, Chill Time, Hop Times, Hop Info, Manual State Change
BLYNK_WRITE(V15)
{
  switch (param.asInt()){
       case 1 : 
        terminal.println("Variables Reset");
        terminal.flush(); 
        autostart = false;
        premash = false;
        mashPID = false;
        reheatpremash = false;
        mashrun = false;
        mashreheat = false;
        mashend = false;
        boilrun = false;
        reboil = false;
        boilend = false;
        chillrun = false;
        rechill = false;
        chillend = false;
        terminal.println("Reverted Back to Pre-Mash Stage");
        terminal.flush(); 
        switchState = 1;
        break;
       case 2 : 
        terminal.println("Variables Reset");
        terminal.flush(); 
        autostart = false;
        premash = false;
        mashPID = false;
        reheatpremash = false;
        mashrun = false;
        mashreheat = false;
        mashend = false;
        boilrun = false;
        reboil = false;
        boilend = false;
        chillrun = false;
        rechill = false;
        chillend = false;
        terminal.println("Reverted Back to Mash Stage");
        terminal.flush(); 
        switchState = 3;
        break;
       case 3 : 
        terminal.println("Variables Reset");
        terminal.flush(); 
        autostart = false;
        premash = false;
        mashPID = false;
        reheatpremash = false;
        mashrun = false;
        mashreheat = false;
        mashend = false;
        boilrun = false;
        reboil = false;
        boilend = false;
        chillrun = false;
        rechill = false;
        chillend = false;
        terminal.println("Reverted back to Boil Stage");
        terminal.flush(); 
        switchState = 6;
        break;
   }
}


BLYNK_WRITE(V1)
{
  MASHTEMP= param.asInt();
  terminalHops.print("MASHTEMP SET AS: ");
  terminalHops.println(MASHTEMP);
  terminalHops.flush(); 
}

BLYNK_WRITE(V2)
{
  MASHTIME= param.asInt();
  terminalHops.print("MASHTIME SET AS: ");
  terminalHops.println(MASHTIME);
  terminalHops.flush(); 
}

BLYNK_WRITE(V3)
{
  BOILTIME= param.asInt();
  terminalHops.print("BOILTIME SET AS: ");
  terminalHops.println(BOILTIME);
  terminalHops.flush(); 
}
  
BLYNK_WRITE(V13)
{
  CHILLTIME= param.asInt();
  terminalHops.print("CHILLTIME SET AS: ");
  terminalHops.println(CHILLTIME);
  terminalHops.flush(); 
}

BLYNK_WRITE(V14)  // Terminal for HOPTIME and HOPINFO input
{
  String fromTerminal = param.asStr();
  
    
  if (fromTerminal.endsWith("?")) {
   terminalHops.println("Comma delimited, and first letter followed by '!' resets previous inputs: HOPTIMES:start w/ 'T,'//HOPINFO: starts w/ 'I,'");
   terminalHops.flush(); 
      }
  
  if (fromTerminal.startsWith("T") ) { //Hoptimes input
      int lastIndex;
      
      if (fromTerminal.endsWith("!")){ //In case I need to reset everything and re input hop additions
       hopCounter = 0;
       lastIndex = 0;
      }
      
      fromTerminal.remove(0,1);
      for (int i = 0; i < fromTerminal.length(); i++) {
        if (fromTerminal.substring(i, i+1) == ",") {
          HOPTIME[hopCounter] = (fromTerminal.substring(lastIndex, i)).toInt();
          lastIndex = i + 1;
          hopCounter++;
        }
        if (i == fromTerminal.length() - 1) {  // If we're at the end of the string (no more commas to stop us)
          HOPTIME[hopCounter] = (fromTerminal.substring(lastIndex, i)).toInt();
        }
      }   
      terminalHops.print(HOPTIME[1]);
      terminalHops.print(" from ArrayHOPTIME ");
      terminalHops.print(hopCounter);
      terminalHops.println(" total inputs");
      terminalHops.flush();
      }

 
  
  if (fromTerminal.startsWith("I")){ //Hopinfo input
      int counter;
      int lastIndex;
      
      if (fromTerminal.endsWith("!")){ //In case I need to reset everything and re input hop additions
       counter = 0;
       lastIndex = 0;
      }
      
      fromTerminal.remove(0,1);
      for (int i = 0; i < fromTerminal.length(); i++) {
        if (fromTerminal.substring(i, i+1) == ",") {
          HOPINFO[counter] = fromTerminal.substring(lastIndex, i);
          lastIndex = i + 1;
          counter++;
        }
        if (i == fromTerminal.length() - 1) {  // If we're at the end of the string (no more commas to stop us)
          HOPINFO[counter] = fromTerminal.substring(lastIndex, i);
        }
      }   
      terminalHops.print(HOPINFO[1]);
      terminalHops.print(" from CharArrayHOPINFO ");
      terminalHops.print(counter);
      terminalHops.println(" total inputs");
      terminalHops.flush();        
      }
 } 

////Manual Controls
BLYNK_WRITE(V4) //Start Button
{
  val_start= param.asInt();
}

BLYNK_WRITE(V5) //Pause Button
{
  val_pause= param.asInt();
}

BLYNK_WRITE(V6) //Pump Button
{
  val_pump= param.asInt();
}

BLYNK_WRITE(V7) //Heater 1 Button
{
  val_heater1= param.asInt();
}

BLYNK_WRITE(V8) //Heater 2 Button
{
  val_heater2= param.asInt();
}


void setup() 
{
  Serial.begin(115200);
  Blynk.begin(auth,ssid,password);
  timer.setInterval(1000, brewingstuff); //Check my brewing code every 1s
  sensor.begin();
  sensor.setResolution(9); //Resolution of 9 means 0.5degC increments.
  pinMode(PUMP, OUTPUT); //initialize pin locations as output or input
  pinMode(HEATER1, OUTPUT);
  pinMode(HEATER2, OUTPUT);
  pinMode(BUZZER, OUTPUT);
  terminal.println("Setup done, Phil's beer is on the way, Ready?");
  terminal.flush();
}

void loop() 
{
  Blynk.run();
  timer.run();
  sensor.requestTemperatures(); //Get TEMP reading continuously
  tanktemp = sensor.getTempFByIndex(0);
}
7

Well, tbh, the code is really long, so much is true, but it makes perfect sense. It’s not that complicated and you’d expect things like to work like a charm.

The only thing I’d change is to also put the temperature reading in a Timed event. You can run that every second if you want (and I guess that is enough, right?). Other than that I can see no obvious errs or something. So, all things being equal, the most simple explenation tends to be the right one (or whatever remains, however improbable, bla bla bla), could it be the hardware? Do you use the same relays for the heaters? I have a couple who switch on HIGH and some who switch on LOW.

Furthermore, in the setup() part, I’d set the digitalWrite for the output pins all to LOW. So that you can be sure everything is turned off when something resets or other scary stuff happens.

You may want to get another another ESP and try to reproduce the problem with a very basic code, just a couple buttons with Blynk to switch On/Off the heaters and see what happens.

8

Yeah its a long code, basically I am not sure why this works:

if (val_start == LOW && val_pause == LOW && val_heater2 == HIGH){
      switch (h2counter){
      case 0:
        btstart2=(millis()/60000);
        tone(BUZZER,500,5000);
        terminal.println("Heat 2 starting, need cover w water!!");
        terminal.flush();
        digitalWrite(HEATER2, HIGH);
        h2counter=1;
      break;
      case 1:
       elapsedh2time = ((millis()/60000) - btstart2);
       terminal.print("Manual Heater 2 On for: ");
       terminal.println(elapsedh2time);
       terminal.flush();
      break;} 
  } 
///When Heater2 button on and then turned off it stops two heater
if (h2counter == 1 && val_heater2 == LOW){
        h2counter = 0;
        digitalWrite(HEATER2, LOW);}

Yet this doesnt:

case 3:
switchState = 0;
mashrun = true;
premash=false;
MashStartTime = (millis()/60000);
digitalWrite(HEATER1, LOW);
digitalWrite(HEATER2, LOW);
digitalWrite(PUMP, HIGH);
tone(BUZZER,500,2000);
terminal.println(“Mash temp hit, mash begin”);
terminal.flush();
break;

9

I will test out your suggestions and maybe something will work out

10

It says in your statement if(h2counter == 1 && val_heater2 == low) as conditions, are you absolutely sure this is the case? It may also be prudent to output some serial output or terminal output to determine every value every step of the way. It seems a bit weird to me that val_heater2 == low and turning it off in the same conditional statement.

11

Trying to read the temperature a thousand times a second can’t be right.

When you have this sort of thing in the loop the rest of your code can fail quite easily.

To be honest for brewing I would have thought temperature readings at 5 or 10 second intervals should be more than adequate. Why push the system more than you need to?

1 Like
12

val_heater2 in my code is associated with my button in blynk, so when button is off I want to turn the HEATER2 pin low.

That represents the manual control of my heaters via a button. While the section not working is inside my Autobrewing code which heaters are triggered by timing/temperature. However in my Autobrewing code, my other HEATER1 works and so does my PUMP. So it is only HEATER2 that is not responding during Autobrewing.

13

I just originally put this into the loop before I began setting everything up in functions. Your right, I dont need temp more than maybe every 30 seconds and even that is really overkill

If for nothing else I will do this to improve stability.

14

Did I miss something in your entire code? Because I’m getting an error on compiling complaining the sensor is not initialized. I’ve setup a Wemos to emulate the brewery (I was thinking of putting in LED’s just for shows).

15

@Lichtsignaal looks like it is missing from @philmurp’s sketch.

Do you have a DS18B20 as I could give you the code required to go with the sensor.getTempFByIndex(0) but it would be better if @philmurp provides the missing lines of code?

16

Yeah, I can figure it, but it would be best if he provided it ofc :slight_smile:

-edit-

@philmurp can you post some screenshots of your dashboard layout in non-running state? I think I made some errors setting up widgets, but I’d love to figure out why this is not working :slight_smile:

1 Like
17

Sorry, thought it grabbed my whole code here is the beginning part:

#include 
#include 
#include 
#define ONE_WIRE_BUS D1 //Sensor location
OneWire oneWire(ONE_WIRE_BUS); 
DallasTemperature sensor(&oneWire);

Not sure why the libraries after #include are not showing up; but it is the DS18b20 library and I forget one other library; I could get the details after work if needed.

Attached are the screenshots of my parameter input tab, dashboard tab, and historical graph tab

IMG_1055.jpg750Ă—1334 50.5 KB

IMG_1054.jpg750Ă—1334 45 KB

IMG_1056.jpg750Ă—1334 46.6 KB

18

I haven’t got a clue what is not right here. I’ve done everything exactly as you (except the temp sensor, I just set it to 0 to trigger events) and some different pin numbers. The Heater lights go on and off with the different stages, also from heater2.

How are you powering your relays b.t.w.? I was thinking some relays, especially China ones, tend to be not 100% reliable. It could be they require more power than a ESP can deliver (they switch on 5v states, not 3.3v). Could be an issue. I really can’t see anything wrong with your code.

19

Should be using LED for code testing, not actual heater elements!

20

Why not? At least that way you know your relays are triggered. I’m using physical LED’s and they do very well, on and off, so it’s more likely there is some sort of weird hardware issue.